]> dgit.raspbian.org Git - gnome-shell.git/commit
status/network: Ensure the Cancel button passes undefined to close()
authorDaniel van Vugt <daniel.van.vugt@canonical.com>
Fri, 12 Mar 2021 06:13:18 +0000 (14:13 +0800)
committerDaniel van Vugt <daniel.van.vugt@canonical.com>
Mon, 15 Mar 2021 10:19:04 +0000 (18:19 +0800)
commitc5b18ee66a8658c743ba11c945569756be39632f
tree1c93d678d317e83934e6103fe90580677f10ebd7
parenta24c1d28ebd9218ac1219f5d10cb249d5722cd9a
status/network: Ensure the Cancel button passes undefined to close()

The parameter to `ModalDialog.close(timestamp)` is optional. But when
invoked via the network dialog's Cancel button it was receiving an
implicit parameter value that's definitely not a timestamp:

```
[0x560f18af0c50 StButton.modal-dialog-linked-button:first-child hover ("Cancel")]
```

And as of today (or gjs >= 1.67.3) that's reported as an error:
```
JS ERROR: Error: Argument timestamp: value is out of range for uint32
popModal@resource:///org/gnome/shell/ui/main.js:638:12
popModal@resource:///org/gnome/shell/ui/modalDialog.js:206:14
close@resource:///org/gnome/shell/ui/modalDialog.js:179:14
```
and so you can't Cancel the dialog anymore.

Make sure `ModalDialog.close()` receives an `undefined` timestamp it
knows how to handle.

Fixes: https://bugs.launchpad.net/bugs/1918666
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1757>
js/ui/status/network.js